New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
show update source on new rows, ensure auto update warning is in modal for failed preflights as well #2336
show update source on new rows, ensure auto update warning is in modal for failed preflights as well #2336
Conversation
@@ -637,7 +631,9 @@ class AppVersionHistory extends Component { | |||
// This is kinda hacky. This finds the equivalent downstream version because the midstream | |||
// version type does not contain metadata like version label or release notes. | |||
const currentMidstreamVersion = versionHistory.find(version => version.parentSequence === app.currentVersion.sequence) || app.currentVersion; | |||
|
|||
const olderVersions = versionHistory.filter((i, idx) => idx !== 0); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what does this do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why index 0?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
filters out the first or latest version since we pin that one to the top of the list. "olderVersions" is probably the wrong name, "otherAvailableVersions" is probably better
@@ -266,7 +250,8 @@ export default function AppVersionHistoryRow(props) { | |||
const { version, selectedDiffReleases, nothingToCommit, | |||
isChecked, isNew, renderSourceAndDiff, handleSelectReleasesToDiff, | |||
yamlErrorsDetails, gitopsEnabled, toggleShowDetailsModal, latestVersion } = props; | |||
|
|||
|
|||
const hideSourceDiff = version?.source.includes("Airgap Install") || version?.source.includes("Airgap Update") || version?.source.includes("Online Install"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Airgap Update" should definitely have a diff
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also, we don't how a diff summary for the initial version today, do we?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No we don't, only for updates
4d83754
to
1308705
Compare
…l for failed preflights as well
02bffe5
to
9656adc
Compare
* add dropdown for automatic installs * Sort releases by semver if available * Semver auto deploy (#2300) * Semver auto deploy api side * Disambiguate sorting for versions with the same semver * pick highest semver not lowest one (#2302) * Hook semver auto deploy dropdown to api (#2306) * hook semver auto deploy to api * add note to dropdown regarding automatic install only happening for valid semver versions (#2305) * add note to dropdown regarding automatic install only happening for valid semver versions * move cron job description text * move description text for auto deploy new versino * reword * Grayson/semvered versions updates (#2308) * add note to dropdown regarding automatic install only happening for valid semver versions * move description text for auto deploy new versino * link out to semver.org * Grayson/semvered versions updates (#2309) * add note to dropdown regarding automatic install only happening for valid semver versions * move description text for auto deploy new versino * use semantic version instead of semver * Sort versions on semver and sequence * Fix bubble sort * Semver auto deploy schedules (#2311) * Semver auto deploy schedules * Revert "Semver auto deploy schedules (#2311)" (#2316) This reverts commit f602cda. * disable automatic deployments when deploying a past version (#2318) * refactor/reword automatic update checks (#2319) * refactor/reword automatic update checks * reconfigure update checker when disabling automatic deployments (#2320) * Base license change on latest version * Save use correct versions when viewing and saving settings * message showing that auto deploy will be turned off when depolying an older version (#2325) * Updating registry should use the correct base version * Remove duplicate function * View files takes user to top release as sorted by semver * use the correct cursor and base version when checking for updates (#2322) * use the correct cursor when checking for updates * UI features are based on semver sorting order * Allow editing pending semver versions * show update source on new rows, ensure auto update warning is in modal for failed preflights as well (#2336) * show update source on new rows, ensure auto update warning is in modal for failed preflights as well * updates * feat: ability to deploy a specific version label during update checks (#2340) * mocked version should be at the top of the list not the bottom * fix: use the right base sequence for semantic versions (#2342) * send app installation time when checking for updates (#2350) * send app installation time when checking for updates * Revert "send app installation time when checking for updates (#2350)" (#2353) This reverts commit a901235. * hide send to vendor button if airgap installed (#2356) * Fix check for new channel after license sync * use last update check at time when fetching updates (#2355) * use last update check at time when fetching updates * fix ci tests Co-authored-by: Grayson Null <graysonnull@me.com> Co-authored-by: divolgin <dmitriy@replicated.com> Co-authored-by: divolgin <divolgin@users.noreply.github.com>
No description provided.