add current and available release version to upstream upgrade cmd #2380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morningvera
force-pushed
the
upstream-upgrade-version
branch
from
129921a
to
c28cad5
Compare
morningvera
force-pushed
the
upstream-upgrade-version
branch
from
c28cad5
to
b67d67a
Compare
morningvera
changed the title
morningvera
changed the title
morningvera
commented
Dec 7, 2021
| } | ||
|
|
||
| var availableReleases []UpdateCheckRelease | ||
| availableSequence := appVersions.AllVersions[0].Sequence + 1 |
There was a problem hiding this comment.
having to do this because new versions aren't immediately assigned sequence numbers. open to feedback if you can think of something better.
There was a problem hiding this comment.
"make a new command that just returns the available, parsed versions" is what I see as better here :)
though this is better than nothing for the command we have
|
JSON output:
text output:
|
|
JSON error output:
text error output:
|
laverya
reviewed
Dec 7, 2021
laverya
approved these changes
Dec 7, 2021
laverya
approved these changes
Dec 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
kind/enhancement
What this PR does / why we need it:
This PR adds the current and latest versions to the output of
kots upstream upgrade. This includes the sequence numbers and semver labels. For the latest versions, all new available versions are listed. Customers are expected to store those available versions if needed because they won't be returned again after they're pulled.36671
Special notes for your reviewer:
Feel free to suggest any name changes on the JSON output.
Does this PR introduce a user-facing change?
Does this PR require documentation?
NONE