Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't surface errors that are not relevant to application #2411

Merged
merged 2 commits into from Dec 20, 2021

Conversation

divolgin
Copy link
Member

@divolgin divolgin commented Dec 18, 2021

What type of PR is this?

kind/bug

What this PR does / why we need it:

This limits analyzers to namespaces relevant to application in cases when kotsadm has cluster access in existing cluster installs.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Fixes a bug that caused analyzers to surface errors in namespaces not used by the application when Admin Console has cluster access in existing cluster installs.

Does this PR require documentation?

NONE

@divolgin divolgin requested a review from a team December 18, 2021 00:49
@divolgin divolgin changed the title Bump troubleshoot to v0.26.0 Don't surface errors that are not relevant to application Dec 18, 2021
@divolgin divolgin merged commit 34b53e9 into main Dec 20, 2021
@divolgin divolgin deleted the divolgin/namespaces branch December 22, 2021 18:30
Copy link

@label-checker label-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Label type:: is required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants