Populated KnownImages value in the installation file #2414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanStough
previously approved these changes
Dec 23, 2021
divolgin
force-pushed
the
divolgin/all-images
branch
from
5d7c5b4
to
c714045
Compare
DanStough
approved these changes
Dec 23, 2021
![label-checker[bot]](https://avatars.githubusercontent.com/u/8120523?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
kind/bug
What this PR does / why we need it:
When running garbage collection in private registry, Admin Console uses the
KnownImageslist to determine what images can be deleted. Under some conditions, that list was not being populated, which would cause garbage collection to ignore corresponding images in the registry.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Does this PR require documentation?
NONE