Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

detect minio image based on the kurl or existing instance #2527

Merged

Conversation

jala-dx
Copy link
Contributor

@jala-dx jala-dx commented Feb 12, 2022

What type of PR is this?

type::bug

What this PR does / why we need it:

We cannot really run Node() API unless the kotsadm has cluster wide privileges

Hence added the given below logic to detect the instance type first and accordingly detect the MinIO image

   In existing install with limited RBAC, kotsadm does not have previliges to run Nodes() API.
   If it is a kurl instance, then use search logic to find the best minio image.
   If it is not a kurl instance, return the static image name present in the bundle.

Which issue(s) this PR fixes:

SC-39403

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


@jala-dx jala-dx requested a review from a team February 12, 2022 01:56
Copy link

@label-checker label-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Label type:: is required.

@jala-dx jala-dx force-pushed the jalaja/fix-snapshot-settings-on-existing-cluster-with-min-rbac branch from c7bc401 to 1e5be59 Compare February 12, 2022 02:03
Copy link

@label-checker label-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Label type:: is required.

@jala-dx jala-dx merged commit 8985152 into main Feb 13, 2022
@jala-dx jala-dx deleted the jalaja/fix-snapshot-settings-on-existing-cluster-with-min-rbac branch February 13, 2022 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants