use correct property name in MonacoDiffEditor to fix diff versions vi… #2533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![label-checker[bot]](https://avatars.githubusercontent.com/u/8120523?s=60&v=4){kind=small}
sgalsaleh
approved these changes
Feb 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
type::bug
What this PR does / why we need it:
We need to fix the diff view! This PR fixes the view by using the correct property name in MonacoDiffEditor.
Which issue(s) this PR fixes:
Fixes https://github.com/replicated-collab/puppet-kots/issues/201
Special notes for your reviewer:
See attached screenshot. I confirmed this diff view matches what it previously was before bug was introduced. In screenshot I added an Ingress definition to the application and show the diff between new version w/ Ingress and previous version without.
Does this PR introduce a user-facing change?
Does this PR require documentation?
NONE
