feat: cli will attempt to reconnect port-forward if disconnected #2543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
divolgin
reviewed
Feb 22, 2022
divolgin
previously approved these changes
Feb 22, 2022
cbodonnell
force-pushed
the
craigodonnell/sc-43634/the-port-forward-to-access-the-admin-console
branch
from
1158f78
to
13ff39b
Compare
divolgin
approved these changes
Feb 23, 2022
cbodonnell
deleted the
craigodonnell/sc-43634/the-port-forward-to-access-the-admin-console
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
type::feature
What this PR does / why we need it:
The port-forward to the kotsadm pod will be disconnected if the pod is destroyed. This PR will make the CLI automatically attempt to re-establish port-forwarding.
Which issue(s) this PR fixes:
Fixes SC-43634
Does this PR introduce a user-facing change?
Does this PR require documentation?
NONE