Allow gitops to be disabled when there is not a valid config #2568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![label-checker[bot]](https://avatars.githubusercontent.com/u/8120523?s=60&v=4){kind=small}
sgalsaleh
approved these changes
Mar 1, 2022
syntastical
approved these changes
Mar 1, 2022
divolgin
reviewed
Mar 3, 2022
| @@ -48,21 +48,24 @@ mock: | |||
| mockgen -source=pkg/handlers/interface.go -destination=pkg/handlers/mock/mock.go | |||
|
|
|||
| .PHONY: build | |||
| build: kots | |||
There was a problem hiding this comment.
this will slow down make build run in okteto
There was a problem hiding this comment.
it's a LOT faster actually. b/c of https://github.com/replicatedhq/kots/pull/2568/files#diff-74f62fd3e5365a996fe97efc3e10ce260f3a62058e08a169de326d8c97680006R157
so the build cache is there, it's taking ~ 10 seconds to build right now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
type::bug
What this PR does / why we need it:
Which issue(s) this PR fixes:
Allows gitops to be disabled when it's enabled but has an invalid config. Before this change, you were required to fix the configuration and then disable.
Does this PR require documentation?
no