allow reupload of license if app is not installed #2577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![label-checker[bot]](https://avatars.githubusercontent.com/u/8120523?s=60&v=4){kind=small}
sgalsaleh
reviewed
Mar 3, 2022
stefanrepl
force-pushed
the
stefan/sc-36475/allow-reupload-lic-if-install-fails
branch
from
af4b1ad
to
b3ce183
Compare
sgalsaleh
requested changes
Mar 3, 2022
sgalsaleh
reviewed
Mar 3, 2022
sgalsaleh
reviewed
Mar 3, 2022
sgalsaleh
reviewed
Mar 3, 2022
stefanrepl
force-pushed
the
stefan/sc-36475/allow-reupload-lic-if-install-fails
branch
2 times, most recently
from
9145e68
to
daf09f0
Compare
done, moved to a shared function and added its use to automated installs |
stefanrepl
force-pushed
the
stefan/sc-36475/allow-reupload-lic-if-install-fails
branch
from
daf09f0
to
98f31f0
Compare
sgalsaleh
reviewed
Mar 4, 2022
sgalsaleh
reviewed
Mar 4, 2022
stefanrepl
force-pushed
the
stefan/sc-36475/allow-reupload-lic-if-install-fails
branch
from
98f31f0
to
c58c1ae
Compare
sgalsaleh
reviewed
Mar 4, 2022
sgalsaleh
reviewed
Mar 4, 2022
sgalsaleh
reviewed
Mar 4, 2022
stefanrepl
force-pushed
the
stefan/sc-36475/allow-reupload-lic-if-install-fails
branch
from
c58c1ae
to
840d212
Compare
sgalsaleh
reviewed
Mar 4, 2022
stefanrepl
force-pushed
the
stefan/sc-36475/allow-reupload-lic-if-install-fails
branch
5 times, most recently
from
ab99110
to
5084c58
Compare
stefanrepl
force-pushed
the
stefan/sc-36475/allow-reupload-lic-if-install-fails
branch
from
5084c58
to
c694c19
Compare
sgalsaleh
reviewed
Mar 4, 2022
sgalsaleh
reviewed
Mar 4, 2022
stefanrepl
force-pushed
the
stefan/sc-36475/allow-reupload-lic-if-install-fails
branch
from
c694c19
to
51ae0ef
Compare
sgalsaleh
previously approved these changes
Mar 4, 2022
stefanrepl
force-pushed
the
stefan/sc-36475/allow-reupload-lic-if-install-fails
branch
from
51ae0ef
to
fddd350
Compare
sgalsaleh
approved these changes
Mar 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
type::bug
What this PR does / why we need it:
This PR allows a user to reupload a license if the license has not been used for a successful installation. Makes UX much smoother so the user does not have to manually run a command to remove the app.
Which issue(s) this PR fixes:
Fixes SC-36475
Special notes for your reviewer:
Tested in Okteto, Okteto endpoint for kots web: https://kotsadm-web-stefanrepl.replicated.okteto.dev/.
Does this PR introduce a user-facing change?
Does this PR require documentation?