Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI to copy Admin Console images to private registry #2579

Merged
merged 1 commit into from
Mar 3, 2022
Merged

CLI to copy Admin Console images to private registry #2579

merged 1 commit into from
Mar 3, 2022

Conversation

divolgin
Copy link
Member

@divolgin divolgin commented Mar 3, 2022 •
edited

What type of PR is this?

type::feature

What this PR does / why we need it:

This is required in order to do auto-upgrades when Admin Console images are used with a private registry.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

This CLI is hidden and will not be documented yet. Usage looks like this:

$ ./bin/kots admin-console push-images docker.io ttl.sh/divolgin
Copying minio/minio:RELEASE.2022-01-08T03-11-54Z to ttl.sh/divolgin/minio:RELEASE.2022-01-08T03-11-54Z
Copying blob 0e3d9ac748ab skipped: already exists  
...
Copying config c0092c1ed2 done  
Writing manifest to image destination
Storing signatures
Copying kotsadm/kotsadm-migrations:v1.59.2 to ttl.sh/divolgin/kotsadm-migrations:v1.59.2
...
Copying config 0ed0ea7b7c done  
Writing manifest to image destination
Storing signatures
...

Does this PR introduce a user-facing change?

* Added experimental CLI for copying Admin Console images to a private registry

Does this PR require documentation?

NONE

@divolgin divolgin requested a review from a team March 3, 2022 01:52
label-checker[bot]
label-checker bot suggested changes Mar 3, 2022
View reviewed changes
Copy link

@label-checker label-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Label type:: is required.

@divolgin divolgin added team::orange type::feature New feature or request labels Mar 3, 2022
@divolgin
Copy link
Member Author

divolgin commented Mar 3, 2022

Another ngrok failure:

Page 'https://cd85606660c8.ngrok.io/' is not available

@divolgin divolgin merged commit c9a7d70 into main Mar 3, 2022
@divolgin divolgin deleted the divolgin/copy-images branch March 3, 2022 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@label-checker label-checker[bot] label-checker requested changes

@sgalsaleh sgalsaleh sgalsaleh approved these changes

Assignees
No one assigned
Labels
team::orange type::feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@divolgin @sgalsaleh