Copy kots images to private registry if one is configured during self-updates #2586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgalsaleh
reviewed
Mar 4, 2022
sgalsaleh
reviewed
Mar 4, 2022
| @@ -1145,6 +1145,12 @@ class AppVersionHistory extends Component { | |||
| checkingUpdateTextShort = checkingUpdateTextShort.slice(0, 30) + "..."; | |||
| } | |||
|
|
|||
| const renderKotsUpgradeStatus = this.state.kotsUpdateStatus && !this.state.kotsUpdateMessage; | |||
There was a problem hiding this comment.
why not show them together? just curious
There was a problem hiding this comment.
i don't have a screenshot, but it looks weird, confusing, and redundant
sgalsaleh
previously approved these changes
Mar 4, 2022
divolgin
force-pushed
the
divolgin/upgrades
branch
from
749eb91
to
74b061d
Compare
sgalsaleh
approved these changes
Mar 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Self-updates will copy images to private registries automatically. This is part of the self-updating feature, so no separate release notes are needed.
type::feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Does this PR require documentation?
NONE