Fix ngrok failures #2598
Merged
Fix ngrok failures #2598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syntastical
force-pushed
the
fix-ngrok-failures
branch
from
e9af95f
to
e8f8279
Compare
syntastical
force-pushed
the
fix-ngrok-failures
branch
from
9508c9d
to
260101a
Compare
sgalsaleh
reviewed
Mar 10, 2022
| exit $EXIT_CODE | ||
|
|
||
| - name: delete velero namespace | ||
| run: kubectl delete namespace velero |
There was a problem hiding this comment.
why remove this? it was causing issues before.
There was a problem hiding this comment.
Each run/job should be on it's own VM, but also the namespace is deleted at the beginning of this step (even though it shouldn't be needed), so this was redundant
sgalsaleh
approved these changes
Mar 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Remove the need for tunneling with testim and improve performance for pull request testing
Which issue(s) this PR fixes:
Fixes #NONE
Special notes for your reviewer:
NONE
Does this PR introduce a user-facing change?
Does this PR require documentation?
NONE