remove extra slash in snapshot bucket path #4590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laverya
approved these changes
May 2, 2024
sgalsaleh
approved these changes
May 2, 2024
cbodonnell
deleted the
cbo/sc-104151/remove-extra-slash-from-the-bucket-on-the
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR addresses an issue where the dashboard snapshot card would show an extra slash if the user entered a bucket prefix with a leading slash in the snapshot settings. This changes the logic to handle cases with and without a leading slash in the bucket path.
Before:
After:
Which issue(s) this PR fixes:
Fixes https://app.shortcut.com/replicated/story/104151/remove-extra-slash-from-the-bucket-on-the-dr-card-on-the-dashboard
Special notes for your reviewer:
Steps to reproduce
Does this PR introduce a user-facing change?
Does this PR require documentation?