github actions for kotsadm #572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laverya
reviewed
May 21, 2020
| path: ./kotsadm/bin | ||
|
|
||
| - name: Download web artifact | ||
| if: ${{ steps.get_tag.outputs.GIT_TAG != '' }} |
There was a problem hiding this comment.
is there a way to put the 'if' a level higher?
There was a problem hiding this comment.
no, because github has no global level tag variable. it has to be generated as a step inside each job
There was a problem hiding this comment.
job level condition can be controlled with on.push.tags, but that applies to the entire workflow and then we'd have to have separate workflows for tagged and untagged steps, and there would be a lot of duplication.
laverya
approved these changes
May 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.