Kotsadm works with HTTP_PROXY #605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add proxy template functions
areed
commented
May 29, 2020
| @@ -66,7 +66,7 @@ export class VeleroClient { | |||
| if (!cluster) { | |||
| throw new Error("No cluster available from kubeconfig"); | |||
| } | |||
| this.server = cluster.server; | |||
| this.server = "https://kubernetes.default" | |||
There was a problem hiding this comment.
This was the cluster IP of the kubernetes service. No proxy includes the whole service CIDR but this node library does not handle cidrs.
| @@ -22,6 +22,7 @@ var ( | |||
| TLSClientConfig: &tls.Config{ | |||
| InsecureSkipVerify: true, | |||
| }, | |||
| Proxy: http.ProxyFromEnvironment, | |||
There was a problem hiding this comment.
GraphQL calls this by FFI when testing registry credentials.
divolgin
approved these changes
May 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes template functions for proxy and no_proxy.
There was a docker library that that didn't have an option to configure the http client so the original plan of using
PROXY_ADDRESSenv var and opting-in for non-cluster requests didn't work. Instead replicatedhq/kURL#486 expands the NO_PROXY var to include all in-cluster hostnames.