Hide yamlErrors for now #819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GraysonNull
approved these changes
Jul 20, 2020
| @@ -140,7 +140,8 @@ class AppVersionHistory extends Component { | |||
| const { app } = this.props; | |||
| const downstream = app.downstreams[0]; | |||
| const diffSummary = this.getVersionDiffSummary(version); | |||
| const hasYamlErrors = this.hasYamlErrors(downstream, version); | |||
| let hasYamlErrors = this.hasYamlErrors(downstream, version); | |||
| hasYamlErrors = false; | |||
There was a problem hiding this comment.
Is the intent to have this always return false?
There was a problem hiding this comment.
yes. there is a bug. we need to fix that. also i think maybe we should find a better way to visualize these errors to the end user.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.