Fix: upstream update should deploy #831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
divolgin
reviewed
Jul 22, 2020
|
|
||
| // get the first version, the array must contain versions at this point | ||
| // this function can't run without an app | ||
| latestVersion := allVersions[len(allVersions)-1] |
There was a problem hiding this comment.
judging by the implementation for GetVersions, this could be an empty array
There was a problem hiding this comment.
i'll add a check here. my comment was more about "many many other places above me in the call stack would have failed, and it's impossible to reach this point". but fair, i'll add
divolgin
approved these changes
Jul 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #827