Reduce image size, copy with chown flag #852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emosbaugh
commented
Jul 24, 2020
| @@ -35,25 +35,20 @@ RUN curl -L "https://github.com/replicatedhq/troubleshoot/releases/download/v0.9 | |||
| mv /tmp/troubleshoot.so /lib/troubleshoot.so && \ | |||
| rm -rf /tmp/* | |||
|
|
|||
| RUN apt-get update && apt-get install -y --no-install-recommends \ | |||
| curl ca-certificates \ | |||
There was a problem hiding this comment.
this is also on line 11
emosbaugh
commented
Jul 24, 2020
| COPY ./web/dist /web/dist | ||
| USER root | ||
| RUN chmod a+x /kotsadm | ||
| RUN chmod a+w /web/dist/* |
There was a problem hiding this comment.
why does this need write?
divolgin
approved these changes
Jul 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will reduce the image size by about 549.2M if it does break anything :)