Use proxy info from environment in kotsadm API #880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
divolgin
force-pushed
the
divolgin/proxies
branch
from
7f9fdd8
to
cd3d51d
Compare
|
@divolgin the implementation here looks good, but should this be opt-in via a CLI flag? |
divolgin
force-pushed
the
divolgin/proxies
branch
from
cd3d51d
to
1b94146
Compare
marccampbell
requested changes
Jul 30, 2020
divolgin
force-pushed
the
divolgin/proxies
branch
from
1b94146
to
7459296
Compare
marccampbell
approved these changes
Jul 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #770