Do not fail on license sync error on application updates #899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
divolgin
approved these changes
Aug 4, 2020
GraysonNull
pushed a commit
that referenced
this pull request
Aug 4, 2020
* Do not fail on license sync error on appication updates * fixes * log error * fail on license sync
GraysonNull
added a commit
that referenced
this pull request
Aug 4, 2020
… newer releases (#905) * support showing error when generating a diff was unsuccessful * Do not fail on license sync error on application updates (#899) * Do not fail on license sync error on appication updates * fixes * log error * fail on license sync * Diff renderedcontents handler return error response on failed kustomize build * handle unable to generate diff errors * update var name * update conditional Co-authored-by: emosbaugh <ethan@replicated.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.