Do not re-deploy first version of the app when preflights succeed #973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emosbaugh
force-pushed
the
preflight-deploy-first-version
branch
from
d70e7e9
to
e1e5703
Compare
sgalsaleh
reviewed
Aug 20, 2020
| @@ -74,8 +74,9 @@ func (s S3PGStore) ListInstalledApps() ([]*apptypes.App, error) { | |||
| } | |||
|
|
|||
| func (s S3PGStore) GetApp(id string) (*apptypes.App, error) { | |||
| logger.Debug("getting app from id", | |||
| zap.String("id", id)) | |||
| // too noisy | |||
sgalsaleh
approved these changes
Aug 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.