Migrate snapshotDetail and restoreDetail to go api #987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emosbaugh
force-pushed
the
go-api-snapshotDetail-restoreDetail
branch
from
29b01e7
to
18f9648
Compare
emosbaugh
changed the title
divolgin
reviewed
Aug 24, 2020
| } | ||
|
|
||
| type SnapshotHook struct { | ||
| Name string `json:"name"` | ||
| Namespace string `json:"namespace"` | ||
| Phase string `json:"pase"` | ||
| Phase string `json:"phase"` |
There was a problem hiding this comment.
Does this change not break anything?
There was a problem hiding this comment.
i dont see anything using .pase but i dont know
divolgin
reviewed
Aug 24, 2020
divolgin
approved these changes
Aug 24, 2020
sgalsaleh
reviewed
Aug 24, 2020
sgalsaleh
reviewed
Aug 24, 2020
sgalsaleh
approved these changes
Aug 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.