Merge pull request #1070 from replicatedhq/ship-config-renderer-to-em…

…it-data-changes Ship config renderer to emit data changes
replicatedhq · Sep 25, 2019 · 24641e0 · 24641e0
2 parents 0d5af63 + 4d34c86
commit 24641e0
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/web/init/package.json b/web/init/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@replicatedhq/ship-init",
-  "version": "1.6.7",
+  "version": "1.6.8",
   "description": "Shared component that contains the Ship Init app",
   "author": "Replicated, Inc.",
   "license": "Apache-2.0",

diff --git a/web/init/src/ShipConfigRenderer.jsx b/web/init/src/ShipConfigRenderer.jsx
@@ -9,8 +9,9 @@ import "./scss/index.scss";
 
 export class ShipConfigRenderer extends React.Component {
   static propTypes = {
-    /** Config groups itesms to render */
-    groups: PropTypes.array.isRequired,
+    groups: PropTypes.array.isRequired, // Config groups items to render
+    handleChange: PropTypes.func,
+    getData: PropTypes.func,
   }
 
   static defaultProps = {
@@ -32,8 +33,7 @@ export class ShipConfigRenderer extends React.Component {
         <ConfigRender
           fieldsList={groupsList}
           fields={_groups}
-          handleChange={() => { return; }}
-          getData={() => { return; }}
+          handleChange={this.props.handleChange}
         />
       </div>
     )

diff --git a/web/init/src/components/config_render/ConfigRender.jsx b/web/init/src/components/config_render/ConfigRender.jsx
@@ -79,7 +79,7 @@ export default class ConfigRender extends React.Component {
     this.setState({groups: keyBy(groups, "name")});
 
     // TODO: maybe this should only be on submit
-    this.triggerChange(this.props.getData(groups));
+    this.triggerChange(groups);
   }
 
   componentDidUpdate(lastProps) {