This repository has been archived by the owner on Mar 24, 2023. It is now read-only.
persist custom json6902 patches in overlays dir #1049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I Did
kustomization.yamlwithin the overlays directory is stored and only the resources/bases/patches are modified. This allows PatchesJSON6902 (closes #1037, closes #730) to be persisted when running ship, among other things.How I Did it
The kustomization file is added to the ship state in a manner that will not be included in any jsonified versions of the state, and modifications are made to this stored file instead of starting from scratch.
How to verify it
The json patch newly included within the
k8s-new-filesship update integration test is persisted and applied within the rendered output.Description for the Changelog
patchesJson6902within user kustomization is persisted inship updateandship editPicture of a Ship (not required but encouraged)