This repository has been archived by the owner on Mar 24, 2023. It is now read-only.
improve handling of docker url dests and add UrlPathEscape template function #1059
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I Did
Fixed #1054
Added
UrlPathEscape
template functionSped up
make build
andmake test
by usingGO111MODULE=off
for calls togoimports
How I Did it
The template function just calls
url.PathEscape
, and parallels the existingUrlEncode
template function (which callsurl.QueryEscape
)Also handled an error where the update code could attempt to remove files from the URL's path within the filesystem. (dests are parsed as urls and checked for a scheme of "docker" - if the parsing passes and the scheme matches, the dest is not considered for removal)
How to verify it
Modify the yaml in #1054 to use UrlPathEscape:
and push to a GCR repository as described
Description for the Changelog
UrlPathEscape
, template function to encode parts of a URL's path has been addedPicture of a Ship (not required but encouraged)