Skip to content
This repository has been archived by the owner on Mar 24, 2023. It is now read-only.

Fix conflict between two select_one items with same name but different groups #1105

Merged
merged 2 commits into from
Mar 5, 2020
Merged

Fix conflict between two select_one items with same name but different groups #1105

merged 2 commits into from
Mar 5, 2020

Conversation

sgalsaleh
Copy link
Member

What I Did

Fix conflict between two select_one items with same name but different groups

How I Did it

add the group to the input id in the ConfigRadio component

How to verify it

Description for the Changelog

Picture of a Ship (not required but encouraged)

dexhorthy
dexhorthy reviewed Mar 5, 2020
View reviewed changes
Copy link
Member

@dexhorthy dexhorthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if both select_one config items are in the same group? Or is group here not referring to the top level groups key?

@sgalsaleh
Copy link
Member Author

@dexhorthy group here refers to the ConfigItem and not the ConfigGroup, which is a bit confusing, but i did not want to mess up the whole code for this fix.

@sgalsaleh sgalsaleh merged commit 05f2156 into master Mar 5, 2020
@sgalsaleh sgalsaleh deleted the select-one-items-same-name-conflict branch March 5, 2020 22:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dexhorthy dexhorthy dexhorthy left review comments

@GraysonNull GraysonNull GraysonNull approved these changes

@jgruica jgruica Awaiting requested review from jgruica

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sgalsaleh @dexhorthy @GraysonNull