Skip to content
This repository has been archived by the owner on Mar 24, 2023. It is now read-only.

Improve Progress messages during docker operations #787

Merged
merged 1 commit into from Jan 8, 2019

Conversation

dexhorthy
Copy link
Member

@dexhorthy dexhorthy commented Jan 8, 2019

Better progress message detail during docker operations, include image name

What I Did

Improve progress messages during docker operations in render step.

How I Did it

  • Add image field to images.Progress
  • Send image down to client
  • Client reads image and other status fields
  • Client shows layer name under progress bar
  • Add debug logging during docker pull

How to verify it

Run a ship yaml with a

assets:
  v1:
  - docker:
      image: postgres:9.6
      dest: ./postgres.tar
lifecycle:
  v1:
    - render {}

See fancy messages on render step.

screen shot 2019-01-07 at 5 29 50 pm

Description for the Changelog

Improve progress messages during docker operations in render step.

…e name

What I Did
------------

Improve progress messages during docker operations in `render` step.

How I Did it
------------

- Add `image` field to `images.Progress`
- Send image down to client
- Client reads `image` and other status fields
- Client shows layer name under progress bar
- Add debug logging during docker pull

How to verify it
------------

Run a ship yaml with a
```yaml

assets:
  v1:
  - docker:
      image: postgres:9.6
      dest: ./postgres.tar
lifecycle:
  v1:
    - render {}
```

See fancy messages on render step.

Description for the Changelog
------------

Improve progress messages during docker operations in `render` step.

:boat:
@dexhorthy dexhorthy requested a review from laverya January 8, 2019 01:34
@dexhorthy dexhorthy changed the title Fix missing state file path in error message on "ship update" Improve Progress messages during docker operations Jan 8, 2019
@dexhorthy dexhorthy merged commit e52fa60 into replicatedhq:master Jan 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants