-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make ConfigMap collector namespace-optional #1212
Conversation
Using the test spec from my PR:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with a suggestion, and a caveat of there has been some discussion recently if we should ever use the kubeconfig
context's namespace at all. Not sure what the argument is there, but i don't object to this change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with a suggestion, and a caveat of there has been some discussion recently if we should ever use the kubeconfig
context's namespace at all. Not sure what the argument is there, but i don't object to this change.
Co-authored-by: Diamon Wiggins <38189728+diamonwiggins@users.noreply.github.com>
Description, Motivation and Context
When no namespace is given in the ConfigMaps collector spec, use the namespace from the current kubectl context.
Fixes: #907
Checklist
Does this PR introduce a breaking change?