Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get cluster-resources even if negotiating RBAC fails #1243

Merged
merged 3 commits into from
Jun 27, 2023
Merged

get cluster-resources even if negotiating RBAC fails #1243

merged 3 commits into from
Jun 27, 2023

Conversation

adamancini
Copy link
Member

Description, Motivation and Context

#1167

kubernetes/kubernetes#65744 leads some clusters using authorization webhooks to fail to report a users' authorizations correctly, so cluster-resources collector skips over some namespaces.

Checklist

  • New and existing tests pass locally with introduced changes.
  • Tests for the changes have been added (for bug fixes / features)
  • The commit message(s) are informative and highlight any breaking changes
  • Any documentation required has been added/updated. For changes to https://troubleshoot.sh/ create a PR here

Does this PR introduce a breaking change?

  • Yes
  • No

@adamancini adamancini marked this pull request as ready for review June 26, 2023 17:19
@adamancini adamancini requested a review from a team as a code owner June 26, 2023 17:19
@adamancini adamancini added the type::bug Something isn't working label Jun 26, 2023
diamonwiggins
diamonwiggins approved these changes Jun 26, 2023
View reviewed changes
Copy link
Member

@diamonwiggins diamonwiggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@xavpaice xavpaice merged commit 58c4283 into replicatedhq:main Jun 27, 2023
21 of 42 checks passed
@xavpaice xavpaice linked an issue Jun 27, 2023 that may be closed by this pull request
clusterResources skips several parts for GKE clusters, without namespace specified #1167
Closed
@xavpaice xavpaice mentioned this pull request Jun 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diamonwiggins diamonwiggins diamonwiggins approved these changes

Assignees
No one assigned
Labels
bug::normal type::bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

clusterResources skips several parts for GKE clusters, without namespace specified
3 participants
@adamancini @diamonwiggins @xavpaice