Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improve flaky goldpinger test #1463

Merged
merged 1 commit into from Feb 9, 2024
Merged

fix: improve flaky goldpinger test #1463

merged 1 commit into from Feb 9, 2024

Conversation

banjoh
Copy link
Member

@banjoh banjoh commented Feb 9, 2024 •
edited

Description, Motivation and Context

We do not need to check if goldpinger pinged or not. At times it would have successful pings that lead to test failures. Its enough to just check that we have analysis results

Checklist

  • New and existing tests pass locally with introduced changes.
  • Tests for the changes have been added (for bug fixes / features)
  • The commit message(s) are informative and highlight any breaking changes
  • Any documentation required has been added/updated. For changes to https://troubleshoot.sh/ create a PR here

Does this PR introduce a breaking change?

  • Yes
  • No

@banjoh
fix: improve flaky goldpinger test
21d1dca 
We do not need to check if the goldpinger pinged or not. At times
it has successful pings that lead to test failures. Its enough to
just check that we have analysis results
@banjoh banjoh added the type::bug Something isn't working label Feb 9, 2024
@banjoh banjoh requested a review from a team as a code owner February 9, 2024 16:18
@banjoh banjoh merged commit fad7a26 into replicatedhq:main Feb 9, 2024
25 checks passed
@banjoh banjoh deleted the em/flaky-goldpinger-test branch February 9, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diamonwiggins diamonwiggins diamonwiggins approved these changes

Assignees
No one assigned
Labels
bug::regression type::bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@banjoh @diamonwiggins