Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add delay between approving and merging PR in the automated PRs manager #1493

Merged
merged 1 commit into from Feb 27, 2024
Merged

Add delay between approving and merging PR in the automated PRs manager #1493

merged 1 commit into from Feb 27, 2024

Conversation

sgalsaleh
Copy link
Member

@sgalsaleh sgalsaleh commented Feb 27, 2024 •
edited

Description, Motivation and Context

Merging PRs occasionally fails due to some race condition. I believe this might fix the issue.

Checklist

  • New and existing tests pass locally with introduced changes.
  • Tests for the changes have been added (for bug fixes / features)
  • The commit message(s) are informative and highlight any breaking changes
  • Any documentation required has been added/updated. For changes to https://troubleshoot.sh/ create a PR here

Does this PR introduce a breaking change?

  • Yes
  • No

@sgalsaleh sgalsaleh requested a review from a team as a code owner February 27, 2024 00:37
@xavpaice xavpaice merged commit 2eb3aa9 into main Feb 27, 2024
27 checks passed
@xavpaice xavpaice deleted the sleep-after-approving-pr-in-automated-prs-manager branch February 27, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xavpaice xavpaice xavpaice approved these changes

Assignees
No one assigned
Labels
type::security
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sgalsaleh @xavpaice