Quick fix to prevent panic on nil collector result #1508

nvanthao · 2024-03-14T06:13:43Z

Description, Motivation and Context

Fixes: #1442

Quick fix before we can refractor the collector, I think we should not mutate the result in defer block.

New and existing tests pass locally with introduced changes.
Tests for the changes have been added (for bug fixes / features)
The commit message(s) are informative and highlight any breaking changes
Any documentation required has been added/updated. For changes to https://troubleshoot.sh/ create a PR here

quick fix to prevent panic on nil collector result

0b645cc

nvanthao requested a review from a team as a code owner March 14, 2024 06:13

nvanthao added bug::regression type::bug Something isn't working labels Mar 14, 2024

do not save pod details on error

348d4c3

nvanthao requested a review from banjoh March 17, 2024 21:23

xavpaice approved these changes Mar 18, 2024

View reviewed changes

nvanthao merged commit 6f839b3 into main Mar 18, 2024
27 checks passed

nvanthao deleted the gerard/b-panic-run-pod branch March 18, 2024 05:42