feat: [sc-103754] Be able to detect search domain misconfiguration #1391 #1534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvanthao
force-pushed
the
gerard/sc-103754/f-dns-collector
branch
from
e1f2ff0
to
d0501b0
Compare
|
I really like this, but aren't we already collecting the coredns config as a configmap? |
|
Indeed we already collecting coredns config map in support bundle. This is just for convenience. Currently we have to do few grep and jq filter to extract Other data such as endpoints is also in support bundle but not ready to be extracted from |
nvanthao
force-pushed
the
gerard/sc-103754/f-dns-collector
branch
from
1a22548
to
d1b96de
Compare
|
it looks like you're still tweaking a few things. lmk when this is ready for review and I'll give it a proper look over |
|
many thanks @danj-replicated! The code is ready for review, I've just rebased to main. |
danj-replicated
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1391
This PR automates some of the steps in Kubernetes document on troubleshooting DNS
https://kubernetes.io/docs/tasks/administer-cluster/dns-debugging-resolution/
I originally plan to use
busyboxas the test pod butnslookupdoes not run correctly in that image. Hence I used this imageregistry.k8s.io/e2e-test-images/jessie-dnsutils:1.3from Kubernetes document.