Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(analyzer): make sure ReplicaSetStatus has valid result #1538

Merged
merged 3 commits into from
Apr 30, 2024

Conversation

DexterYan
Copy link
Member

@DexterYan DexterYan commented Apr 30, 2024

Description, Motivation and Context

  • check result of analyzeReplicaSetStatus to be nil or not
  • add missing nil result check for analyzeOneReplicaSetStatus

According user, we have another issue

  • Listing releases
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x3 pc=0x2ca2d13]

goroutine 1484 [running]:
github.com/replicatedhq/troubleshoot/pkg/analyze.(*AnalyzeReplicaSetStatus).Analyze(0xc001454ec0, 0x7323368?, 0xc001a1b2f0?)
	/var/cache/melange/gomodcache/github.com/replicatedhq/troubleshoot@v0.88.0/pkg/analyze/replicaset_status.go:50 +0x53

Checklist

  • New and existing tests pass locally with introduced changes.
  • Tests for the changes have been added (for bug fixes / features)
  • The commit message(s) are informative and highlight any breaking changes
  • Any documentation required has been added/updated. For changes to https://troubleshoot.sh/ create a PR here

Does this PR introduce a breaking change?

  • Yes
  • No

@DexterYan DexterYan requested a review from a team as a code owner April 30, 2024 04:45
@DexterYan DexterYan added type::bug Something isn't working bug::normal labels Apr 30, 2024
@DexterYan DexterYan merged commit cb5db17 into main Apr 30, 2024
27 checks passed
@DexterYan DexterYan deleted the dx/fix-analyzer-nil branch April 30, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug::normal type::bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants