allow textAnalyze to run on all files in a dir or matching a prefix #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doing so sort of breaks the 'invalid analyzer' message if no files match
…zing-all-files-in-dir
![codelingo[bot]](https://avatars.githubusercontent.com/in/14339?s=60&v=4){kind=small}
| getFiles := func(n string) (map[string][]byte, error) { | ||
| matching := make(map[string][]byte) | ||
| for k, v := range test.files { | ||
| if strings.HasPrefix(k, n) { |
There was a problem hiding this comment.
Using continue here is less conditionally indented and more readable.
There was a problem hiding this comment.
I don't think this one is relevant
There was a problem hiding this comment.
@CodeLingoBot reply @laverya nice catch! Next time you can just reply to the bot like this and it'll pop up on the rule chat. What minimum number of lines do you think we need within the if statement before wanting to avoid nesting? Also @marccampbell? Any thoughts on this (reply on the rule chat and I'll tighten up the rule linter accordingly).
sgalsaleh
approved these changes
Sep 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #173