Add scrolling to table, use table widget for support bundle #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GraysonNull
changed the title
![codelingo[bot]](https://avatars.githubusercontent.com/in/14339?s=60&v=4){kind=small}
There was a problem hiding this comment.
@GraysonNull Can you attach a couple of screenshots showing the previous and the new terminal UI here for review?
| return lines | ||
| } | ||
|
|
||
| // func drawGrid(analyzeResults []*analyzerunner.AnalyzeResult) { |
There was a problem hiding this comment.
What's this unused block for?
There was a problem hiding this comment.
oh shoot, nothing. Just need to remove it
| func showSaved(filename string) { | ||
| termWidth, termHeight := ui.TerminalDimensions() | ||
|
|
||
| savedMessage := widgets.NewParagraph() | ||
| savedMessage.Text = fmt.Sprintf("Preflight results saved to\n\n%s", filename) | ||
| savedMessage.Text = fmt.Sprintf("Support Bundle analysis results saved to\n\n%s", filename) |
| @@ -198,3 +316,19 @@ func save(analyzeResults []*analyzerunner.AnalyzeResult) (string, error) { | |||
|
|
|||
| return filename, nil | |||
| } | |||
|
|
|||
| func appName(supportBundleName string) string { | |||
There was a problem hiding this comment.
This function looks to be copied from elsewhere? Should we move it to a shared package and use the same implementation?
There was a problem hiding this comment.
It is yes. Yep I can move it.
marccampbell
approved these changes
Aug 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.