selector:MatchLabel

[manavellamnimble]

@marccampbell @divolgin @dexhorthy Morning! I am sending a PR to solve issue #159 . I desing the selector label to accept further expansions in the future. Under matchLabel, multiple labels can be used to filter the nodes. The final structure would be something like this:

- nodeResources:
        checkName: Must have at least 3 nodes in the cluster, with cpuCapacity of 2 and label kubernetes.io/hostname=docker-desktop
        filters:
            cpuCapacity: "2"
            selector: 
                matchLabel: 
                    kubernetes.io/hostname  : docker-desktop
        outcomes:
        - fail:
            when: "count() < 3"
            message: This application requires at least 3 nodes.
            uri: https://kurl.sh/docs/install-with-kurl/adding-nodes
        - warn:
            when: "count() < 5"
            message: This application recommends at last 5 nodes.
            uri: https://kurl.sh/docs/install-with-kurl/adding-nodes
        - pass:
            message: This cluster has enough nodes.

[codelingo]

LGTM.

[marccampbell]

@manavellamnimble the matchLabel dictionary feels a little foreign to me, compared to the rest of the Kubernetes API.

If we can match the format of Kubernetes native objects for label selectors (https://kubernetes.io/docs/concepts/overview/working-with-objects/labels/) it will be easier for people to implement because we won't be asking them to change the format and they can re-use existing YAML selectors.

Is is possible to use the standard key=value types here, and use the selector package from client-go to parse so that we match the format and results the same?

[manavellamnimble]

@marccampbell In fact I used a map based on what you mentioned. K8s api uses mostly maps (I called it dictionary, my bad). In the docs there is an example for selectors, following the same structure:

selector:
  matchLabels:
    component: redis

matchLabels is a map of {key,value} pairs.
src: https://kubernetes.io/docs/concepts/overview/working-with-objects/labels/#resources-that-support-set-based-requirements

Regarding using the client, that was also my first approach, but the matchFilter() func uses the info stored in the file nodes.json (created earlier by the collector), thats why I use node.Labels (which is also a map).

Nevertheless, I can adjust the labels as you prefer, it is really not lots of work. Let me know what you think!

[marccampbell]

errors.Errorf

[marccampbell]

Thanks! This lgtm, 1 comment on cleaning up an error string before we can merge

[manavellamnimble]

@marccampbell Great! Done!

[codelingo]

LGTM.