-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check for Default Storage Class when storageClassName is empty #250
Check for Default Storage Class when storageClassName is empty #250
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Hi @manavellamnimble thanks for the PR! I think I'm in favor of only supporting exactly what Kubernetes supports (or what they document to support) -- if adding an annotation value of (string)
But if Kubernetes only parses the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@markpundsack @dexhorthy I've added default messages in case storageClassName is empty and no message is provided. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Logic and messaging looks good to me. I haven't validated the code functionality. |
@marccampbell @dexhorthy Good morning! I send you the PR to check for a storage class set as default when storageClassName is empty. I can add the parse function to parse the string "true" to bool, but it would also consider other values as "True", "T", "TRUE"...and I think k8s only expect the value
true
Closes #200
src: https://kubernetes.io/docs/tasks/administer-cluster/change-default-storage-class/#changing-the-default-storageclass (item 2)