Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ingres analyzer fixed #267

Merged
merged 2 commits into from Sep 17, 2020
Merged

Conversation

manavellamnimble
Copy link
Contributor

@areed @markpundsack Hi! I fixed the ingress analyzer. Tested it locally too and worked

@CLAassistant
Copy link

CLAassistant commented Sep 16, 2020

CLA assistant check
All committers have signed the CLA.

Copy link

@codelingo codelingo bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issues found.

pkg/analyze/ingress.go Outdated Show resolved Hide resolved
Copy link

@codelingo codelingo bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@markpundsack
Copy link
Contributor

@manavellamnimble Awesome, thanks! Can you put back in the documentation on troubleshoot.sh now that https://github.com/replicatedhq/troubleshoot.sh/pull/223/files removed it? And check that the docs are right?

@manavellamnimble
Copy link
Contributor Author

@markpundsack sure! No problem

@divolgin divolgin merged commit 58261cd into replicatedhq:master Sep 17, 2020
@manavellamnimble manavellamnimble deleted the fixIngress branch September 18, 2020 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants