Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove image pull secret path support #274

Conversation

manavellamnimble
Copy link
Contributor

@markpundsack @marccampbell I have removed support for path to config.json. It will only accept a name of a preexisting secret or an encoded string to create a new secret.

Copy link

@codelingo codelingo bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@divolgin divolgin merged commit 446b1d5 into replicatedhq:master Oct 5, 2020
@manavellamnimble manavellamnimble deleted the removeImagePullSecretPathSupport branch October 26, 2020 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants