Collector for RRD data #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
divolgin
commented
Oct 31, 2020
divolgin
force-pushed
the
divolgin/rrd
branch
from
7cb3613
to
8ee4a09
Compare
![codelingo[bot]](https://avatars.githubusercontent.com/in/14339?s=60&v=4){kind=small}
|
|
||
| func getFilesFromPod(ctx context.Context, client *kubernetes.Clientset, c *Collector, podName string, containerName string, namespace string, containerPath string) ([]byte, []byte, error) { | ||
| command := []string{"tar", "-C", filepath.Dir(containerPath), "-cf", "-", filepath.Base(containerPath)} | ||
| req := client.CoreV1().RESTClient().Post().Resource("pods").Name(podName).Namespace(namespace).SubResource("exec") |
There was a problem hiding this comment.
Avoid unnecessary use of client-go restClient
pkg/rrd/rrd_c.go
Outdated
| return append(args, makeArgs(e.args)...) | ||
| } | ||
|
|
||
| func parseInfoKey(ik string) (kname, kkey string, kid int) { |
There was a problem hiding this comment.
Naked returns harm the readability of code, especially in long functions.
pkg/rrd/rrd_c.go
Outdated
| return r | ||
| } | ||
|
|
||
| func parseGraphInfo(i *C.rrd_info_t) (gi GraphInfo, img []byte) { |
There was a problem hiding this comment.
Naked returns harm the readability of code, especially in long functions.
divolgin
force-pushed
the
divolgin/rrd
branch
3 times, most recently
from
897a7a6
to
a384420
Compare
divolgin
force-pushed
the
divolgin/rrd
branch
18 times, most recently
from
836d80c
to
886720e
Compare
| @@ -42,138 +42,154 @@ func isExcluded(excludeVal multitype.BoolOrString) (bool, error) { | |||
| return parsed, nil | |||
| } | |||
|
|
|||
| func (c *Collector) RunCollectorSync(globalRedactors []*troubleshootv1beta2.Redact) (map[string][]byte, error) { | |||
| var unRedacted map[string][]byte | |||
| func (c *Collector) RunCollectorSync(globalRedactors []*troubleshootv1beta2.Redact) (result map[string][]byte, err error) { | |||
There was a problem hiding this comment.
Naked returns harm the readability of code, especially in long functions.
divolgin
force-pushed
the
divolgin/rrd
branch
from
ce29310
to
265f9e1
Compare
divolgin
force-pushed
the
divolgin/rrd
branch
3 times, most recently
from
376e48b
to
72e0708
Compare
sgalsaleh
approved these changes
Nov 10, 2020
divolgin
force-pushed
the
divolgin/rrd
branch
from
72e0708
to
5a1321d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example collector and analyzer
Load value is normalized using the number of CPUs found in the RRD data.