Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pv and pvcs to support bundle #330

Merged
merged 1 commit into from
Feb 26, 2021
Merged

add pv and pvcs to support bundle #330

merged 1 commit into from
Feb 26, 2021

Conversation

jala-dx
Copy link
Contributor

@jala-dx jala-dx commented Feb 26, 2021

No description provided.

@CLAassistant
Copy link

CLAassistant commented Feb 26, 2021

CLA assistant check
All committers have signed the CLA.

@jala-dx jala-dx merged commit ce53dbc into master Feb 26, 2021
@markpundsack
Copy link
Contributor

@jala-dx Cool! Does this behave gracefully with minimalRBAC? Like, will it return PVCs in namespace KOTS has access to, and gracefully skip other namespaces?

@jala-dx
Copy link
Contributor Author

jala-dx commented Feb 26, 2021

@jala-dx Cool! Does this behave gracefully with minimalRBAC? Like, will it return PVCs in namespace KOTS has access to, and gracefully skip other namespaces?

@markpundsack thanks:) ! yes it is a best effort. it walks through all the namespaces in kots and gets the PVCs. For some reason say RBAC, it cannot get, the code skips and continues and gets the next one.

@markpundsack
Copy link
Contributor

Thanks. Have you confirmed that with minimalRBAC, it does as expected, where it includes things in-namespace? I'm just slightly worried that it won't include any PVCs, if, for example, the account doesn't have permission to even list namespaces, but does in fact have access to at least one namespace with a PVC.

@adamancini adamancini deleted the pv-pvc branch December 23, 2022 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants