Danj multiple inputs #683
Merged
Danj multiple inputs #683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dan Jones <danj@replicated.com>
Signed-off-by: Dan Jones <danj@replicated.com>
Signed-off-by: Dan Jones <danj@replicated.com>
Signed-off-by: Dan Jones <danj@replicated.com>
Signed-off-by: Dan Jones <danj@replicated.com>
Signed-off-by: Dan Jones <danj@replicated.com>
divolgin
reviewed
Aug 29, 2022
divolgin
requested changes
Aug 29, 2022
divolgin
reviewed
Aug 29, 2022
divolgin
reviewed
Aug 29, 2022
|
After talking to @diamonwiggins I'm going to move the new methods from the api package to the support-bundle package |
5 tasks
5 tasks
Signed-off-by: Dan Jones <danj@replicated.com>
divolgin
reviewed
Sep 6, 2022
Signed-off-by: Dan Jones <danj@replicated.com>
|
I've tested this manually by adding several bundles at the CLI, some with multiple docs, and a redactor spec. All the bundles were merged as expected, and the redactors ran fine. The changes requested have been taken care of except the go fmt, which I'd like to put into a separate commit. The task that relates to this shouldn't be closed without adding tests, but given the test coverage in the current implementation, I think that can be a separate PR. |
divolgin
previously approved these changes
Sep 8, 2022
Signed-off-by: Dan Jones <danj@replicated.com>
xavpaice
approved these changes
Sep 9, 2022
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to address issue #665
This is by no means a complete implimentation, and relies on #680 to enable collectors to be able to perform "intelligent merging".
but for now it allows multiple specs to be passed to
support-bundleand will aggregate all defined items in the support-bundle spec, with some limited deduplication for cluster-info and cluster-resources collectors.