Added Namespace for Collection and Allows for tests to output to stdout #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bearium thanks for the contribution! This lgtm, and we will include it in our next release (Dec 9) |
divolgin
requested changes
Dec 6, 2019
cmd/preflight/cli/stdout_results.go
Outdated
| fmt.Printf("=== RUN: %s\n", analyzeResult.Title) | ||
| } | ||
| for _, analyzeResult := range analyzeResults { | ||
| outputResult(analyzeResult) |
There was a problem hiding this comment.
outputResult should return the value that is currently stored in the global failed variable. The the global variable should be removed.
laverya
approved these changes
Dec 13, 2019
|
Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--namespace flag can now be passed into the support bundle and will now only collect resource information from specified namespace. if flag not specified default cluster wide resource collection is used.
--interactive=false now results in tests printing to stdout in go test format, allows for easier and quicker test inspection
go mod tidy was ran to clean up dependencies