Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev replikation #18

Merged
merged 10 commits into from
Jan 20, 2021
Merged

Dev replikation #18

merged 10 commits into from
Jan 20, 2021

Conversation

replikation
Copy link
Owner

@replikation replikation commented Jan 19, 2021

  • living PR on code rewrite and test profiles

@hoelzer
Copy link
Collaborator

hoelzer commented Jan 19, 2021

@working guppy CPU #20 I can test this if you want (do we have some test fast5 somewhere, OSF?)

This was linked to issues Jan 19, 2021
@replikation
Copy link
Owner Author

replikation commented Jan 19, 2021

-profile test_fast5 @hoelzer see help; fastq fasta and fast5 can be "auto supplied" for testing

@hoelzer
Copy link
Collaborator

hoelzer commented Jan 19, 2021

-profile test_fast5 @hoelzer see help fastq fasta and fast5 can be "auto supplied" for testing

ah, awesome! I will test!

btw you switched to V1200 primer set as the default now? (its fine, just to know because e.g. P3 uses V3 currently)

@replikation
Copy link
Owner Author

replikation commented Jan 19, 2021

V3 should be the default; its only set to V1200 for the test fastq set (as i only had a good and small one for V1200)

@hoelzer
Copy link
Collaborator

hoelzer commented Jan 19, 2021

V3 should be the default; its only set to V1200 for the test fastq set (as i only had a good and small one for V1200)

ah, I see. great!

@hoelzer hoelzer mentioned this pull request Jan 19, 2021
@replikation
Copy link
Owner Author

@replikation replikation self-assigned this Jan 20, 2021
@replikation replikation added the enhancement New feature or request label Jan 20, 2021
@hoelzer
Copy link
Collaborator

hoelzer commented Jan 20, 2021

@replikation looks good!

  • I just updated president
  • and I switched from baseName to simpleName for fastq input because otherwise I ended up with something like FAO96286_barcode07.fastq_seq_ident_check.tsv because baseName did not remove the .fastq from a .fastq.gz file

@replikation replikation merged commit f46e2b4 into master Jan 20, 2021
@replikation replikation deleted the dev_replikation branch January 21, 2021 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CPU support for Guppy basecalling threads for guppy
2 participants