Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

entity/touch entity/get not resolving db/ident #59

Closed
boxxxie opened this issue Aug 4, 2019 · 4 comments
Closed

entity/touch entity/get not resolving db/ident #59

boxxxie opened this issue Aug 4, 2019 · 4 comments

Comments

@boxxxie
Copy link

boxxxie commented Aug 4, 2019

I have a DB where i have a bunch of idents, and when i get an entity out of the DB and use (get) or (touch) which uses an ident ref, it will come back as a set of :db/id

Is the expected behaviour for get or touch in this case to give me back the translated value of the ident (in this case keywords)?

also, possibly related, when i use (walk/postwalk identity entity) this throws an error. this is something that works in datomic.

anyway, if idents are supposed to resolve the way i described, i can try to add that functionality, otherwise working with idents seems to be a big PITA.

@boxxxie boxxxie changed the title entity/touch entity/get not resolving db/ident resolving entity/touch entity/get not resolving db/ident Aug 4, 2019
@boxxxie
Copy link
Author

boxxxie commented Aug 5, 2019

After looking up this topic for a while, i think this is the correct behaviour in terms of returning {:db/ident :ident-name} when being touched. to me it seems like it lowers the utility of idents.

however, the (walk identity entity) code throwing errors seems wrong. i've looked over the entity namespace, and i'm not really sure how to go about fixing this behaviour

@kordano
Copy link
Member

kordano commented Aug 6, 2019

I'll have a look at it @boxxxie . Could you add some code example, so I can reproduce this behaviour? Thanks.

@boxxxie
Copy link
Author

boxxxie commented Aug 7, 2019

I'll try up something soon that uses datomic and datahike side by side for this issue.

@kordano
Copy link
Member

kordano commented Aug 8, 2019

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants