Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

transact vs transact! #77

Closed
cjsauer opened this issue Oct 3, 2019 · 2 comments
Closed

transact vs transact! #77

cjsauer opened this issue Oct 3, 2019 · 2 comments

Comments

@cjsauer
Copy link

cjsauer commented Oct 3, 2019 •
edited

Hi there 👋

Amazing project, thank you for sharing.

Out of curiosity, why transact instead of transact!? Both DataScript and Datomic use the bang ! convention, I'm wondering why Datahike doesn't do the same.
@whilo
Copy link
Member

whilo commented Oct 3, 2019

transact is actually the one used by Datomic and our api namespace focuses on Datomic compatibility while we internally still use most of the DataScript conventions:

https://docs.datomic.com/on-prem/clojure/index.html#datomic.api/transact

The bang notation is unfortunately only losely used in Clojure land as far as I can tell. I think transact! corresponds to transact-async in Datomic @kordano.

@cjsauer
Copy link
Author

cjsauer commented Oct 3, 2019

🤦‍♂ oops, I misremembered, should've done a bit more research. Sorry for the noise here.

@cjsauer cjsauer closed this as completed Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cjsauer @whilo