Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

19 circle ci #20

Merged
merged 5 commits into from
Jan 24, 2019
Merged

19 circle ci #20

merged 5 commits into from
Jan 24, 2019

Conversation

kordano
Copy link
Member

@kordano kordano commented Jan 23, 2019

No description provided.

@kordano kordano requested a review from whilo January 23, 2019 12:33
@kordano kordano mentioned this pull request Jan 23, 2019
Closed
@kordano kordano added the Ready for review Pull request ready for review label Jan 23, 2019
@kordano kordano added this to In progress in Development via automation Jan 23, 2019
@kordano kordano moved this from In progress to Needs review in Development Jan 23, 2019
@kordano
Copy link
Member Author

kordano commented Jan 23, 2019

Resolves #19

@kordano kordano removed this from Needs review in Development Jan 23, 2019
@kordano kordano added this to In progress in Development via automation Jan 23, 2019
@kordano kordano moved this from In progress to Needs review in Development Jan 23, 2019
whilo
whilo approved these changes Jan 24, 2019
View reviewed changes
Copy link
Member

@whilo whilo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Development automation moved this from Needs review to Reviewer approved Jan 24, 2019
@whilo whilo merged commit 28bf431 into master Jan 24, 2019
Development automation moved this from Reviewer approved to Done Jan 24, 2019
@kordano kordano mentioned this pull request Jan 24, 2019
Closed
@kordano kordano deleted the 19_circle_ci branch July 23, 2019 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whilo whilo whilo approved these changes

Assignees
No one assigned
Labels
Ready for review Pull request ready for review
Projects
No open projects
Development
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kordano @whilo