Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DynamoDB support. #86

Closed
wants to merge 1 commit into from
Closed

DynamoDB support. #86

wants to merge 1 commit into from

Conversation

csm
Copy link

@csm csm commented Nov 8, 2019

Uses konserve-ddb.

  • src/datahike/config.cljc (::backend): add :ddb.
    (do-uri->config): new multimethod, dispatch on backend.
    Provide :ddb implementation.
    (uri->config): defer to do-uri->config.
  • src/datahike/store.cljc: add implementations for :ddb.
  • project.clj: add konserve-ddb (as provided dependency).

@noonhomie
DynamoDB support.
149fd94 
* src/datahike/config.cljc (::backend): add :ddb.
  (do-uri->config): new multimethod, dispatch on backend.
  Provide :ddb implementation.
  (uri->config): defer to do-uri->config.
* src/datahike/store.cljc: add implementations for :ddb.
* project.clj: add konserve-ddb (as provided dependency).
@kordano kordano self-requested a review November 11, 2019 12:03
@csm
Copy link
Author

csm commented Nov 14, 2019

#89 may be more interesting than this.

@whilo
Copy link
Member

whilo commented Nov 15, 2019

In some sense you have parametrized konserve there so that it is able to cover the functionality in this branch as well, right?

@csm
Copy link
Author

csm commented Nov 15, 2019

Yes, with konserve-ddb-s3 just pass something that returns true for all keys to consistent-key and everything would be stored in DynamoDB. Though it would be odd to have to pass in a valid S3 bucket even though it's never used.

@kordano
Copy link
Member

kordano commented Sep 16, 2020

Since Datahike now uses external backend libraries over protocols I'll have to close this PR. I'll try to move it to a separate project.

@kordano kordano closed this Sep 16, 2020
@kordano kordano mentioned this pull request Sep 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kordano kordano Awaiting requested review from kordano

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@csm @whilo @kordano @noonhomie