Change to new release cycle #73
Conversation
There was a problem hiding this comment.
For now it would be better to base these changes on the master branch since the changes for the sync+async are not yet ported in neither Datahike nor the hitchhiker-tree, and we wanted to prepare a proper release just after 0.6.0-alpha3 without the new changes.
template/pom.xml
Outdated
| <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> | ||
| <modelVersion>4.0.0</modelVersion> | ||
| <groupId>io.replikativ</groupId> | ||
| <artifactId>incognito</artifactId> |
There was a problem hiding this comment.
The descriptions and IDs in here are still for incognito. Please adjust to konserve.
There was a problem hiding this comment.
Sorry, I didn't look at this file. I thought because it is a template, it is general for all libraries. I will adjust this
.circleci/config.yml
Outdated
| at: /home/circleci | ||
| - run: | ||
| name: test | ||
| command: clojure -Sthreads 1 -T:build test |
There was a problem hiding this comment.
I would run ./bin/run-unittests here for now since you're using still kaocha as a test dependency.
build.clj
Outdated
| :src-dirs ["src"]) | ||
| bb/jar)) | ||
|
|
||
| (defn test "Run the tests." [opts] |
There was a problem hiding this comment.
Somehow the tests just say true. Not sure whether this occurred for you as well.
There was a problem hiding this comment.
When I run the kaocha tests locally the true appears prior to the reflection warnings. It turns out, it actually originates from this line.
In fact, with this line, the tests cannot be run via the build script. I suspect that is because a :main-opt is already there so the test runner main doesn't get added (see here).
I find that quite unsatisfying because that means the reflection check has to be taken out of there and I quite liked that check in that spot. There are still libraries from us that show those warnings and it would be good to detect those things early from now on.
|
The hitchhiker-tree is already ported to sync+async and Datahike only needs to bump the hitchhiker-tree version. I don't see a reason to drop back to the master branch, but I might misunderstand what you are trying to do here. |
|
At least when @kordano wrote his review, some tests of the updated hitchhiker tree were still failing, so we couldn't use this version in Datahike yet. By now, we have decided on using the new release cycle with the new changes from the dev branch and keep on using the old konserve version in the meantime though. |
No description provided.